Skip to content

pkg/acquisition: refact configuration validation and tests #4187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmetc merged 25 commits into from
Jan 16, 2026
Merged

pkg/acquisition: refact configuration validation and tests #4187

mmetc merged 25 commits into from
Jan 16, 2026

Conversation

@mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 8, 2026

No description provided.

@mmetc mmetc added this to the 1.7.5 milestone Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc force-pushed the datasource-validation branch from 6d38a47 to ad28309 Compare January 8, 2026 14:00
@codecov
Copy link

codecov bot commented Jan 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.92308% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.99%. Comparing base (c0709b2) to head (af5077e).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/acquisition.go 75.40% 9 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4187      +/-   ##
==========================================
- Coverage   63.39%   62.99%   -0.41%     
==========================================
  Files         451      468      +17     
  Lines       32543    33301     +758     
==========================================
+ Hits        20632    20977     +345     
- Misses       9833    10210     +377     
- Partials     2078     2114      +36
Flag Coverage Δ
bats 46.17% <60.00%> (+0.05%) ⬆️
unit-linux 35.99% <75.38%> (+0.40%) ⬆️
unit-windows 24.30% <69.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmetc mmetc force-pushed the datasource-validation branch 7 times, most recently from 9d1f6b6 to 8e62bef Compare January 12, 2026 14:26
@mmetc mmetc force-pushed the datasource-validation branch from 8e62bef to c2db96a Compare January 12, 2026 14:46
@mmetc mmetc changed the title pkg/acquisition: refact common configuration validation and tests pkg/acquisition: refact configuration validation and tests Jan 13, 2026
@mmetc mmetc force-pushed the datasource-validation branch from 3ae9e0a to 131957e Compare January 13, 2026 12:00
@mmetc mmetc force-pushed the datasource-validation branch 3 times, most recently from bf1be55 to a962aa5 Compare January 14, 2026 08:48
@mmetc mmetc force-pushed the datasource-validation branch from a962aa5 to d4caaed Compare January 14, 2026 09:17
@mmetc mmetc marked this pull request as ready for review January 16, 2026 09:09
sabban
sabban approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 4e0cc46 into master Jan 16, 2026
16 checks passed
@mmetc mmetc deleted the datasource-validation branch January 16, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabban sabban sabban approved these changes

Assignees

@sabban sabban

Labels

kind/refactoring needs/area

Projects

None yet

Milestone

1.7.5

Development

Successfully merging this pull request may close these issues.

3 participants

@mmetc @sabban